riscv64: skip satp Bare-mode switch when already Bare (§V.3 item 7 audit fix)

Browse Source

arch_early_init() unconditionally cleared satp on every boot, justified
only by behavior observed under QEMU/EDK2 firmware (satp.MODE=10/Sv57,
kernel identity-mapped within it). That reasoning never applied to the
native U-Boot+OpenSBI boot path, where satp is conventionally already 0
at S-mode handoff -- the unconditional clear was likely a harmless no-op
there, but on an unverified assumption.

Fix: read satp.MODE first and return early when it's already 0 (nothing
to switch away from, no safety argument needed). The unconditional
csrw/sfence pair still runs unchanged for the confirmed QEMU/EDK2 case.
No Sv39/Sv48/Sv57 page-table walker built -- out of proportion to this
finding's severity.

3-arch acceptance: amd64/aarch64 don't compile this file, so their runs
are non-regression on untouched files only. riscv64's own boot log
confirms satp.MODE = 0xa at entry, so the mode != 0 branch ran and
"satp cleared -- Bare mode, explicit" printed exactly as before the fix.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019YcT3H2PQeyujrzjqS3Var

...

This commit is contained in:

Robert Allan James

2026-09-05 00:17:35 -04:00

co-authored by Claude Sonnet 5

parent 350287850f

commit 90ee8deb6d

10 changed files with 27648 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

logs/20260905-000923/amd64/qemu-amd64-20260905-000923.log

+9187

File diff suppressed because it is too large Load Diff

logs/20260905-001326/aarch64/qemu-aarch64-20260905-001326.log

+9157

File diff suppressed because it is too large Load Diff

logs/20260905-001600/riscv64/qemu-riscv64-20260905-001600.log

+9227

File diff suppressed because it is too large Load Diff